Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Managed Kafka #487

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Support Managed Kafka #487

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d0c26c
Update fields for Managed Kafka and add topics/quotas endpoints
christhemorse Oct 28, 2024
a69b461
Add flags for Managed Kafka advanced config
christhemorse Oct 30, 2024
fe38af1
Merge branch 'master' into support-managed-kafka
christhemorse Oct 30, 2024
d353b1e
Update a few names of Kafka advanced options
christhemorse Oct 30, 2024
ee5630d
Fix typo that was copy/pasted a bunch
christhemorse Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo that was copy/pasted a bunch
  • Loading branch information
@christhemorse
christhemorse committed Oct 31, 2024
commit ee5630da03f6163c3ae97daa733add171e7d2185
34 changes: 17 additions & 17 deletions cmd/database/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,13 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

create.Flags().StringP("database-engine", "e", "", "database engine for the new manaaged database")
create.Flags().StringP("database-engine", "e", "", "database engine for the new managed database")
if err := create.MarkFlagRequired("database-engine"); err != nil {
fmt.Printf("error marking database create 'database-engine' flag required: %v", err)
os.Exit(1)
}

create.Flags().StringP("database-engine-version", "v", "", "database engine version for the new manaaged database")
create.Flags().StringP("database-engine-version", "v", "", "database engine version for the new managed database")
if err := create.MarkFlagRequired("database-engine-version"); err != nil {
fmt.Printf("error marking database create 'database-engine-version' flag required: %v", err)
os.Exit(1)
Expand Down Expand Up @@ -602,12 +602,12 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

userCreate.Flags().StringP("username", "u", "", "username for the new manaaged database user")
userCreate.Flags().StringP("username", "u", "", "username for the new managed database user")
userCreate.Flags().StringP(
"password",
"p",
"",
"password for the new manaaged database user (omit or leave empty to generate a random secure password)",
"password for the new managed database user (omit or leave empty to generate a random secure password)",
)
userCreate.Flags().StringP("encryption", "e", "", "encryption type for the new managed database user (MySQL only)")
userCreate.Flags().StringP("permission", "", "", "permission level for the new managed database user (Kafka only)")
Expand Down Expand Up @@ -648,7 +648,7 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
"password",
"p",
"",
"password for the manaaged database user (omit or leave empty to generate a random secure password)",
"password for the managed database user (omit or leave empty to generate a random secure password)",
)

// User Delete
Expand Down Expand Up @@ -852,7 +852,7 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

dbCreate.Flags().StringP("name", "n", "", "name of the new logical database within the manaaged database")
dbCreate.Flags().StringP("name", "n", "", "name of the new logical database within the managed database")
if err := dbCreate.MarkFlagRequired("name"); err != nil {
fmt.Printf("error marking logical database create 'name' flag required: %v", err)
os.Exit(1)
Expand Down Expand Up @@ -987,7 +987,7 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

topicCreate.Flags().StringP("name", "n", "", "name for the new manaaged database topic")
topicCreate.Flags().StringP("name", "n", "", "name for the new managed database topic")
topicCreate.Flags().IntP("partitions", "p", 0, "partitions for the new managed database topic")
topicCreate.Flags().IntP("replication", "r", 0, "replication factor for the new managed database topic")
topicCreate.Flags().IntP("retention-hours", "", 0, "retention hours for the new managed database topic")
Expand Down Expand Up @@ -1179,7 +1179,7 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

quotaCreate.Flags().StringP("client-id", "", "", "client ID for the new manaaged database quota")
quotaCreate.Flags().StringP("client-id", "", "", "client ID for the new managed database quota")
quotaCreate.Flags().IntP("consumer-byte-rate", "", 0, "consumer byte rate for the new managed database quota")
quotaCreate.Flags().IntP("producer-byte-rate", "", 0, "producer byte rate factor for the new managed database quota")
quotaCreate.Flags().IntP("request-percentage", "", 0, "CPU request percentage for the new managed database quota")
Expand Down Expand Up @@ -1344,7 +1344,7 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
"period",
"p",
"",
"period (day, week, month, year) for viewing service alerts for a manaaged database",
"period (day, week, month, year) for viewing service alerts for a managed database",
)
if err := alertList.MarkFlagRequired("period"); err != nil {
fmt.Printf("error marking alert list 'period' flag required: %v", err)
Expand Down Expand Up @@ -1452,25 +1452,25 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

migrationStart.Flags().String("host", "", "source host for the manaaged database migration")
migrationStart.Flags().Int("port", 0, "source port for the manaaged database migration")
migrationStart.Flags().String("host", "", "source host for the managed database migration")
migrationStart.Flags().Int("port", 0, "source port for the managed database migration")
migrationStart.Flags().String(
"username",
"",
"source username for the manaaged database migration (uses `default` for Redis if omitted)",
"source username for the managed database migration (uses `default` for Redis if omitted)",
)
migrationStart.Flags().String("password", "", "source password for the manaaged database migration")
migrationStart.Flags().String("password", "", "source password for the managed database migration")
migrationStart.Flags().String(
"database",
"",
"source database for the manaaged database migration (MySQL/PostgreSQL only)",
"source database for the managed database migration (MySQL/PostgreSQL only)",
)
migrationStart.Flags().String(
"ignored-dbs",
"",
"comma-separated list of ignored databases for the manaaged database migration (MySQL/PostgreSQL only)",
"comma-separated list of ignored databases for the managed database migration (MySQL/PostgreSQL only)",
)
migrationStart.Flags().Bool("ssl", true, "source ssl requirement for the manaaged database migration")
migrationStart.Flags().Bool("ssl", true, "source ssl requirement for the managed database migration")

// Migration Detach
migrationDetach := &cobra.Command{
Expand Down Expand Up @@ -3856,7 +3856,7 @@ func NewCmdDatabase(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
},
}

versionUpgrade.Flags().StringP("version", "v", "", "version of the manaaged database to upgrade to")
versionUpgrade.Flags().StringP("version", "v", "", "version of the managed database to upgrade to")
if err := versionUpgrade.MarkFlagRequired("version"); err != nil {
fmt.Printf("error marking version upgrade 'version' flag required: %v", err)
os.Exit(1)
Expand Down
Loading