Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requested Changes #8

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Requested Changes #8

merged 5 commits into from
Mar 5, 2021

Conversation

eb3095
Copy link

@eb3095 eb3095 commented Mar 4, 2021

Make requested changes

This makes the changes requested by the cloud-init team.

This cleans up the use of globals, changes logging, changes some variable names, and uses lru_cache

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@eb3095 eb3095 force-pushed the vultr-cloudinit branch from 5d175bc to fc769fc Compare March 4, 2021 20:26
@ddymko ddymko requested review from ddymko and Oogy March 5, 2021 00:26
@Oogy
Copy link

Oogy commented Mar 5, 2021

@eb3095
Does not appear to have addressed:
canonical#827 (comment)
canonical#827 (comment)

@ddymko ddymko merged commit 671ede5 into vultr:vultr-cloudinit Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oogy Oogy Oogy approved these changes

@ddymko ddymko Awaiting requested review from ddymko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eb3095 @Oogy @ddymko