Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix instruction_chain of InBoundsAccessChain #2620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

White-Green
Copy link
Contributor

@White-Green White-Green commented Dec 27, 2024

Fixes: #2619

note:
There are instructions similar to OpInBoundsAccessChain, namely OpPtrAccessChain and OpInBoundsPtrAccessChain. However, I wasn't sure how to handle these, so I have left them as they are.

  1. Update documentation to reflect any user-facing changes - in this repository.

  2. Make sure that the changes are covered by unit-tests.

  3. Run cargo clippy on the changes.

  4. Run cargo +nightly fmt on the changes.

  5. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  6. Describe in common words what is the purpose of this change, related
    GitHub Issues, and highlight important implementation aspects.

Changelog:

### Bugs fixed
- `DescriptorBindingRequirements` not including bindings referenced via `OpInBoundsAccessChain`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with inspect_entry_point in SPIR-V Containing OpInBoundsAccessChain
1 participant