Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): define missing slot types #16621

Merged
merged 6 commits into from
Feb 10, 2023
Merged

fix(types): define missing slot types #16621

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b706e8
refactor: implement genericComponent into components
johnleider Feb 8, 2023
75a6814
refactor: convert more components
johnleider Feb 9, 2023
35dd1d0
refactor: simplify non-generic slots declaration
KaelWD Feb 10, 2023
b344fe6
chore: update new component template
KaelWD Feb 10, 2023
51644fc
fix: correct slot name
KaelWD Feb 10, 2023
b8ed22a
add VSelectionControl label props
KaelWD Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update new component template
  • Loading branch information
@KaelWD
KaelWD committed Feb 10, 2023
commit b344fe60fdeed1fa899c1dfdee8c61dca11682a5
6 changes: 2 additions & 4 deletions templates/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@ import './NAME.sass'
import { genericComponent, useRender } from '@/util'

// Types
import type { MakeSlots, SlotsToProps } from '@/util'
import type { MakeSlots } from '@/util'

export type ComponentSlots = MakeSlots<{
default: []
}>

export const NAME = genericComponent<new () => {
$props: SlotsToProps<ComponentSlots>
}>()({
export const NAME = genericComponent<ComponentSlots>()({
name: 'NAME',

props: {},
Expand Down