Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to webpack-dev-server v4 #6669

Merged
merged 15 commits into from
Sep 15, 2021
+353 −121
Merged

feat!: upgrade to webpack-dev-server v4 #6669

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
87cbb40
feat!: (WIP) upgrade to webpack-dev-server v4
haoqunjiang Sep 3, 2021
a7744a8
chore: add notes about progress plugin
haoqunjiang Sep 3, 2021
de4306d
chore: add https cli arg back
haoqunjiang Sep 3, 2021
08b5439
test: record websocket urls in requestUrls too
haoqunjiang Sep 3, 2021
2b2ef6b
test: update hmr test for websocket connections
haoqunjiang Sep 3, 2021
1f169c3
chore: remove redundant logs
haoqunjiang Sep 3, 2021
95d5e1b
refactor: remove unused variable
haoqunjiang Sep 3, 2021
5e4723b
test: webpack-dev-server seems to no longer accept `//` in url
haoqunjiang Sep 3, 2021
4357739
test: remove `.only` that was used for local debugging
haoqunjiang Sep 7, 2021
206756b
fix: add whatwg-fetch for IE compatibility
haoqunjiang Sep 10, 2021
fa54f68
fix: don't establish extra ws connections for built-in entries
haoqunjiang Sep 10, 2021
28911df
fix: show progress
haoqunjiang Sep 10, 2021
334183b
refactor: use webpack-dev-server's built-in `open` functionality
haoqunjiang Sep 14, 2021
091a356
test: fix windows test
haoqunjiang Sep 14, 2021
d31f19e
docs: complete migration docs [skip ci]
haoqunjiang Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use webpack-dev-server's built-in open functionality
  • Loading branch information
@haoqunjiang
haoqunjiang committed Sep 14, 2021
commit 334183bdb0474d09c4f0f96d2c3be6fd2fb08bed
12 changes: 1 addition & 11 deletions packages/@vue/cli-service/lib/commands/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ const {
error,
hasProjectYarn,
hasProjectPnpm,
openBrowser,
IpcMessenger
} = require('@vue/cli-shared-utils')

Expand Down Expand Up @@ -217,8 +216,7 @@ module.exports = (api, options) => {
...projectDevServerOptions.client
},

// avoid opening browser
open: false,
open: args.open || projectDevServerOptions.open,
setupExitSignals: true,

// eslint-disable-next-line no-shadow
Expand Down Expand Up @@ -319,14 +317,6 @@ module.exports = (api, options) => {
}
console.log()

// fixme: `openPage` is unified into `open`
if (args.open || projectDevServerOptions.open) {
const pageUri = (projectDevServerOptions.openPage && typeof projectDevServerOptions.openPage === 'string')
? projectDevServerOptions.openPage
: ''
openBrowser(localUrlForBrowser + pageUri)
}

// Send final app URL
if (args.dashboard) {
const ipc = new IpcMessenger()
Expand Down