-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mocha): workaround the dart-sass stylesheet load issue #6444
base: dev
Are you sure you want to change the base?
Conversation
e0dcf35
to
d12cd5e
Compare
How about ignoring these style files in the unit test plugin? |
I might be mixing up things, but how would you test css-based things like |
Oops. I forgot about that feature. Because the tests are run in Node.js environment with JSDOM, the And, the default Jest presets provided by Vue CLI never support such usage ( |
Oh didn't know that. Then yeah, you're right, the whole style block of an SFC should simply be ignored. |
I just update my VUE APP to use Dart-Sass and I get this error on all my test because I use a submodule with all my style-sheets there. Any news aproving this PR or @sodatea the ignore all styles aproche got implemented some where?. |
This comment has been minimized.
This comment has been minimized.
Maybe style files can not simply be ignored, since case: <template>
<div :class="$style.hello">
</div>
</template>
<style lang="scss" module>
.hello {
display: none;
}
</style> |
Hey. Thanks for everyones great work on this! I have now also run into this problem. What's the horizon for merging this? |
TODO
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
check #6427 (comment)
It's a hackish workaround, feel free to close it if this is not accepted.
Fixes #6427, Fixes #4053