Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support binary mirrors for taobao registry #4767

Merged
merged 3 commits into from
Nov 1, 2019
Merged

feat: support binary mirrors for taobao registry #4767

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8471070
feat: support binary mirrors for taobao registry
haoqunjiang Oct 29, 2019
3acf202
fix: only install cypress 3, for now
haoqunjiang Oct 29, 2019
dfc42ca
fix: do not override user defined `CYPRESS_INSTALL_BINARY` env
haoqunjiang Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: only install cypress 3, for now
  • Loading branch information
@haoqunjiang
haoqunjiang committed Oct 29, 2019
commit 3acf202b18500bd4debf5e8f5186536c561a35f1
3 changes: 2 additions & 1 deletion packages/@vue/cli/lib/util/ProjectPackageManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ class PackageManager {
const platforms = cypressMirror.newPlatforms || defaultPlatforms
const targetPlatform = platforms[require('os').platform()]
if (targetPlatform) {
const latestCypressVersion = await this.getRemoteVersion('cypress')
// We only support cypress 3 for the current major version
const latestCypressVersion = await this.getRemoteVersion('cypress', '^3')
process.env.CYPRESS_INSTALL_BINARY =
`${cypressMirror.host}/${latestCypressVersion}/${targetPlatform}/cypress.zip`
}
Expand Down