Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update workbox webpack plugin version #4577

Closed
wants to merge 1 commit into from

Conversation

pushpak
Copy link

@pushpak pushpak commented Sep 14, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
This bug was introduced when #4253 was backported to v3 but the workbox-webpack-plugin was not updated to support it

Also, a version bump including this fix would be great.

@pushpak
Copy link
Author

pushpak commented Sep 14, 2019

The appveyor failed build is not related to this PR i guess

@haoqunjiang
Copy link
Member

What bug? workbox version in v3 is intentionally not updated because that will be a breaking change.

@haoqunjiang
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants