Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): ignore core-js sources #3930

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(babel): ignore core-js sources #3930

wants to merge 1 commit into from

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented May 2, 2019

@Akryum Akryum requested a review from haoqunjiang May 2, 2019 12:54
@Akryum Akryum self-assigned this May 2, 2019
@Akryum Akryum added PR: Bug Fix and removed bug labels May 2, 2019
@haoqunjiang
Copy link
Member

The tests are failing.
Honestly I've never encountered such error before…

@Akryum
Copy link
Member Author

Akryum commented May 3, 2019

I encountered it while transpiling (with transpileDependencies) a linked npm package when importing a raw .vue component from said npm package which has a prop with type: Number, which triggers the core-js NumberConstructor polyfill.

@Akryum
Copy link
Member Author

Akryum commented May 3, 2019

The tests are failing.

Looks like it's not allowed inside presets 😿, maybe exclude would work...

@Akryum
Copy link
Member Author

Akryum commented May 3, 2019

Or maybe we can just add it to the generated babel config?

@haoqunjiang
Copy link
Member

Hmmmm…
I think the actual problem here is that linked modules does not work well with webpack exclude. We already excluded node_modules by default,

@Akryum
Copy link
Member Author

Akryum commented May 3, 2019

We already excluded node_modules by default,

The issue arises when manually telling vue-cli to actually transpile the components package

@haoqunjiang
Copy link
Member

oh then it makes sense to fix the exclude pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants