Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon48 prop to iconPaths option to define a favicon to show in Google search result #5041

Open
StaymanHou opened this issue Jan 6, 2020 · 2 comments · May be fixed by #7002
Open

Comments

@StaymanHou
Copy link

What problem does this feature solve?

Currently the plugin only generates favicon16 and favicon32 tags when compiled. That works fine for browsers but doesn't comply with the Google search appearance guidelines for defining a favicon. - https://support.google.com/webmasters/answer/9290858?hl=en

The guidelines specify that a valid favicon must be a multiple of 48px square. Please provide a option to generate a 48x48 favicon tag.

What does the proposed API look like?

pwa.iconPaths

{
  favicon48: 'img/icons/favicon-48x48.png',
  favicon32: 'img/icons/favicon-32x32.png',
  favicon16: 'img/icons/favicon-16x16.png',
  appleTouchIcon: 'img/icons/apple-touch-icon-152x152.png',
  maskIcon: 'img/icons/safari-pinned-tab.svg',
  msTileImage: 'img/icons/msapplication-icon-144x144.png'
}

And generate <link rel=icon type=image/png sizes=48x48 href=img/icons/favicon-48x48.png>

@LinusBorg
Copy link
Member

LinusBorg commented Jan 8, 2020

@sodatea this seems like a good idea. Agree? Then I'll do a PR

@haoqunjiang
Copy link
Member

Looks good 🙂

@LinusBorg LinusBorg self-assigned this Jan 9, 2020
@LinusBorg LinusBorg removed their assignment Mar 10, 2021
@filips123 filips123 linked a pull request Feb 21, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants