-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 release preparation #985
Comments
My suggestion list:
|
Definitely, first comment updated ❤️ 📝 @afontcu @lmiller1990 @cexbrayat Your input will be invaluable here |
I think I have a fix for #806 somewhere, I can get it done this weekend.
I think we should tag all relevant issues with a How about we set a goal to make sure this happens - I'm going to suggest October 31st? |
At the moment I'm seeing this issue: vuejs/vue-test-utils#1833 also in 2.0.0 rc 16. |
@boboldehampsink The issue you're mentioning is for VTU v1 (for Vue v2), whereas this repository is for VTU v2 (for Vue 3) If you're encountering it with Vue 3 and VTU v2, please open a dedicated issue with a reproduction so we can take a look. |
@cexbrayat yes encountering this with Vue 3 and VTU v2. The issue is exactly the same tho. Probably worth fixing in v1 and then you'll be able to fix it for v2 too. |
New issue filed here: #1076 |
Seems, outside of Vue Jest specific problems w.r.t stubs, we are good to hit 2.0.0? |
Once all fails here pass: #1293 we will do 2.0. |
Is it good practice to release a version when the dependencies are yet not published properly. I have seen this with v5 of vue cli jest as well. v2 will hold v27-rc of vue-jest, shouldn't you guys collaborate and ask dependent libraries to publish first. This is not an issue with individual devs but there are scans in place in enterprises, and in my company, we are kind of confused to go with vue 3 now |
It's just a version number - transitioning from RC to 2.0.0 is more or less an arbitrary decision, since there's no official spec to build by. The RC - release candidate - just means "it's pretty much ready for prime time, bar a few known issues". That said, if your company is concerned, the only thing blocking 2.0.0 is two failing tests: #1293. If you (or someone else who's concerned about the RC status) would like to fix those, we can move to 2.0.0 🎉 |
I think this can be closed, as we finally have |
#1253
#1233
#1173
Once these are fixed, we move to 2.0.
Edit: once the tests in this PR pass we move to 2.0: #1293
The text was updated successfully, but these errors were encountered: