Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): inlay hints for <component :is> and <slot :name> #4661

Merged
merged 12 commits into from
Oct 23, 2024
Merged

fix(language-core): inlay hints for <component :is> and <slot :name> #4661

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4101231
feat: pure virtual code support within interpolation
KazariEX Aug 7, 2024
05f4d58
fix: inlay hints for `<component :is>` and `<slot :name>`
KazariEX Aug 7, 2024
2928de4
Merge branch 'master' into fix/issue-4294
KazariEX Aug 7, 2024
a279ac0
chore: merge
KazariEX Aug 7, 2024
099dc98
Merge remote-tracking branch 'origin/main' into fix/issue-4294
KazariEX Aug 11, 2024
3e7dc6e
refactor: use `ctx.inlayHints`
KazariEX Aug 11, 2024
e27e67f
Merge branch 'main' of https://github.com/KazariEX/vuejs-language-too…
KazariEX Aug 26, 2024
96d34ee
test: remove outdated case
KazariEX Aug 26, 2024
962f1b4
Merge branch 'master' into pr/4661
johnsoncodehk Oct 22, 2024
1e84ae7
combine vBindShorthand.ts and types.ts
johnsoncodehk Oct 22, 2024
c75b33b
Update element.ts
johnsoncodehk Oct 23, 2024
4c7c7c8
Update element.ts
johnsoncodehk Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update element.ts
  • Loading branch information
@johnsoncodehk
johnsoncodehk committed Oct 23, 2024
commit c75b33babc4c601c7c9746b1bf1807484bdcce06
8 changes: 3 additions & 5 deletions packages/language-core/lib/codegen/template/element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export function* generateComponent(
exp: CompilerDOM.ElementNode | CompilerDOM.ExpressionNode;
tag: string;
offsets: [number, number | undefined];
isComponentIsShorthand?: boolean;
} | undefined;

if (isComponentTag) {
Expand All @@ -63,11 +62,13 @@ export function* generateComponent(
&& prop.arg?.loc.source === 'is'
&& prop.exp?.type === CompilerDOM.NodeTypes.SIMPLE_EXPRESSION
) {
if (prop.arg.loc.end.offset === prop.exp.loc.end.offset) {
ctx.inlayHints.push(createVBindShorthandInlayHintInfo(prop.exp.loc, 'is'));
}
dynamicTagInfo = {
exp: prop.exp,
tag: prop.exp.content,
offsets: [prop.exp.loc.start.offset, undefined],
isComponentIsShorthand: prop.arg.loc.end.offset === prop.exp.loc.end.offset
};
props = props.filter(p => p !== prop);
break;
Expand Down Expand Up @@ -114,9 +115,6 @@ export function* generateComponent(
yield `]${endOfLine}`;
}
else if (dynamicTagInfo) {
if (dynamicTagInfo.isComponentIsShorthand) {
ctx.inlayHints.push(createVBindShorthandInlayHintInfo(dynamicTagInfo.exp.loc, 'is'));
}
yield `const ${var_originalComponent} = (`;
yield* generateInterpolation(
options,
Expand Down