fixing tslint configuration #1169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
======================================
Coverage 100% 100%
======================================
Files 50 50
Lines 2384 2384
Branches 115 115
======================================
Hits 2384 2384
Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -216,7 +216,7 @@ | |||
| "precompile": "rimraf ./out", | |||
| "compile": "tsc", | |||
| "compile:w": "npm run compile -- -w", | |||
| "lint": "tslint --project tsconfig.json", | |||
| "lint": "tslint --project tsconfig.json --type-check true", | |||
There was a problem hiding this comment.
Not really, you're right.
tslint.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "allow-pascal-case", | |||
| "allow-leading-underscore" | |||
| ], | |||
| "no-submodule-imports": false, | |||
There was a problem hiding this comment.
If we are going to use the setting then better set it to true and exclude vscode.
i. e. no-submodule-imports: [true, "vscode"]
There was a problem hiding this comment.
I'm used to have this disabled from my work with Angular and rxjs but given that here we don't use webpack and we don't do any kind of tree-shaking I can live with it 😉
|
Wait to approve it as I'm also updating the Changelog. |
|
Note that I updated the changelog with September 17 as the new release date but we can advance it if you are ok with it. |
Fixes 'tslint.json' file and a few
double quotes. Several minor package updates.