Update to have lint, watch, and build commands.

vrsource · Apr 21, 2017 · 7cd9a45 · 7cd9a45
1 parent 64d0ed2
commit 7cd9a45
Show file tree

Hide file tree

Showing 9 changed files with 849 additions and 26 deletions.
diff --git a/package.json b/package.json
@@ -20,9 +20,20 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "tslint": "^4.1.1"
+    "tslint": "^4.1.1",
+    "chokidar-cli": "1.2.0"
   },
   "devDependencies": {
     "typescript": "~2.1.0"
+  },
+  "watch": {
+    "test": "rules/*.ts"
+  },
+  "scripts": {
+    "build": "tsc -p .",
+    "lint": "tslint rules/*.ts",
+    "test:once": "./run_tests.sh",
+    "test": "npm run lint && npm run build && npm run test:once",
+    "watch": "chokidar 'rules/*.ts' 'test/**/*' -c 'npm run test'"
   }
 }
diff --git a/rules/literalSpacingRule.js b/rules/literalSpacingRule.js
diff --git a/rules/literalSpacingRule.ts b/rules/literalSpacingRule.ts
@@ -114,10 +114,10 @@ class LiteralSpacingRuleWalker extends Lint.RuleWalker {
             }
 
             if (ALWAYS_OPT === checkType) {
-                if((!is_empty) &&
-                   (edgeText.length === 0) &&
-                   (nodeEdgeChar !== " ")) {
-                    self.addFailure(self.createFailure(start, 1, ALWAYS_FAIL));
+                if ((!is_empty) &&
+                    (edgeText.length === 0) &&
+                    (nodeEdgeChar !== " ")) {
+                     self.addFailure(self.createFailure(start, 1, ALWAYS_FAIL));
                 }
             }
         }

diff --git a/rules/noJasmineFocusRule.js b/rules/noJasmineFocusRule.js
diff --git a/rules/noJasmineFocusRule.ts b/rules/noJasmineFocusRule.ts
@@ -14,7 +14,7 @@ import * as Lint from "tslint";
 import * as ts from "typescript";
 
 const JASMINE_FOCUS_FAIL = "Don't keep jasmine focus methods";
-const BAD_CALL_NAMES     = ['fdescribe', 'fit'];
+const BAD_CALL_NAMES     = ["fdescribe", "fit"];
 
 export class Rule extends Lint.Rules.AbstractRule {
     public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
@@ -28,7 +28,7 @@ class NoJasmineFocusRuleWalker extends Lint.RuleWalker {
         let func_id   = (node.expression as ts.Identifier);
         let func_name = func_id.getText();
 
-        if (BAD_CALL_NAMES.indexOf(func_name) != -1) {
+        if (BAD_CALL_NAMES.indexOf(func_name) !== -1) {
             this.addFailure(this.createFailure(func_id.getStart(), func_id.getWidth(), JASMINE_FOCUS_FAIL));
         }
 

diff --git a/run_tests.sh b/run_tests.sh
@@ -2,7 +2,7 @@
 set -v
 
 # Compile all rules
-./node_modules/.bin/tsc -p .
+#./node_modules/.bin/tsc -p .
 
 # Now run the tests
 #./node_modules/.bin/tslint --test test/rules/no-imports/default

diff --git a/tsconfig.json b/tsconfig.json
@@ -5,6 +5,8 @@
     "removeComments": true,
     "inlineSourceMap": true,
     "preserveConstEnums": true,
-    "strictNullChecks": true
+    "strictNullChecks": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   }
 }
diff --git a/tslint.json b/tslint.json
@@ -34,7 +34,6 @@
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
-    "no-unused-variable": true,
     "no-use-before-declare": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": true,