Merge pull request #164 from pd/enable-refremote-specs

Enable refremote specs
voxpupuli · Oct 31, 2014 · 6f16522 · 6f16522
2 parents e20175d + 879a8a1
commit 6f16522
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 4 deletions.
diff --git a/Gemfile b/Gemfile
@@ -2,7 +2,7 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "json", platform: :ruby_18
+gem "json", :platform => :ruby_18
 
 group :development do
   gem "rake"

diff --git a/json-schema.gemspec b/json-schema.gemspec
@@ -18,4 +18,6 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 1.8.7"
   s.license = "MIT"
   s.required_rubygems_version = ">= 1.8"
+
+  s.add_development_dependency "webmock"
 end
diff --git a/test/test_bad_schema_ref.rb b/test/test_bad_schema_ref.rb
@@ -1,9 +1,18 @@
 require 'test/unit'
+require 'webmock'
 require 'socket'
 require File.dirname(__FILE__) + '/../lib/json-schema'
 
 class BadSchemaRefTest < Test::Unit::TestCase
 
+  def setup
+    WebMock.allow_net_connect!
+  end
+
+  def teardown
+    WebMock.disable_net_connect!
+  end
+
   def test_bad_uri_ref
     schema = {
         "$schema" => "http://json-schema.org/draft-04/schema#",
@@ -25,6 +34,7 @@ def test_bad_host_ref
     }
 
     data = [1,2,3]
+
     assert_raise(SocketError, OpenURI::HTTPError) do
       JSON::Validator.validate(schema,data)
     end

diff --git a/test/test_common_test_suite.rb b/test/test_common_test_suite.rb
@@ -1,4 +1,5 @@
 require 'test/unit'
+require 'webmock'
 require File.expand_path('../../lib/json-schema', __FILE__)
 
 class CommonTestSuiteTest < Test::Unit::TestCase
@@ -16,11 +17,25 @@ class CommonTestSuiteTest < Test::Unit::TestCase
       "ECMA 262 regex dialect recognition/ECMA 262 has no support for lookbehind",
       "ECMA 262 regex dialect recognition/[^] is a valid regex",
     ],
-    "draft3/refRemote.json" => :all,
-    "draft4/optional/format.json" => :all,
-    "draft4/refRemote.json" => :all,
+    "draft4/optional/format.json" => :all
   })
 
+  include WebMock::API
+
+  def setup
+    WebMock.enable!
+
+    Dir["#{TEST_DIR}/../remotes/**/*.json"].each do |path|
+      schema = path.sub(%r{^.*/remotes/}, '')
+      stub_request(:get, "http://localhost:1234/#{schema}").
+        to_return(:body => File.read(path), :status => 200)
+    end
+  end
+
+  def teardown
+    WebMock.disable!
+  end
+
   Dir["#{TEST_DIR}/*"].each do |suite|
     version = File.basename(suite).to_sym
     Dir["#{suite}/**/*.json"].each do |tfile|