Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flashz.hpp #14

Merged
merged 2 commits into from
May 28, 2024
Merged

Update flashz.hpp #14

merged 2 commits into from
May 28, 2024

Conversation

tobozo
Copy link
Contributor

@tobozo tobozo commented May 28, 2024

fix for deprecation warning (arduino-esp32 3.x.x):

/home/runner/.arduino15/packages/esp32/tools/esp32-arduino-libs/idf-release_v5.1-442a798083/esp32/include/esp_rom/include/esp32/rom/miniz.h:7:2: warning: #warning "{target}/rom/miniz.h is deprecated, please use (#include "miniz.h") instead" [-Wcpp]
      7 | #warning "{target}/rom/miniz.h is deprecated, please use (#include "miniz.h") instead"

fix for UpdateClass related error (arduino-esp32 3.x.x):

/home/runner/Arduino/libraries/esp32-flashz/src/flashz.cpp:289:23: error: 'SPI_FLASH_SEC_SIZE' was not declared in this scope; did you mean 'SPI_FLASH_BLOCK_SIZE'?

fix for networkclient related error (arduino-esp32 3.x.x):

/home/runner/Arduino/libraries/esp32-flashz/src/flashz-http.cpp:207:5: error: 'WiFiClient' was not declared in this scope
    207 |     WiFiClient *stream = http.getStreamPtr();

tobozo added 2 commits May 28, 2024 12:27
fix for deprecation warning  (arduino-esp32 3.x.x):

```log
 /home/runner/.arduino15/packages/esp32/tools/esp32-arduino-libs/idf-release_v5.1-442a798083/esp32/include/esp_rom/include/esp32/rom/miniz.h:7:2: warning: #warning "{target}/rom/miniz.h is deprecated, please use (#include "miniz.h") instead" [-Wcpp]
      7 | #warning "{target}/rom/miniz.h is deprecated, please use (#include "miniz.h") instead"
```
arduino-esp32 core 2.x => 3.x migration
@vortigont vortigont merged commit 1466589 into vortigont:main May 28, 2024
2 checks passed
@vortigont
Copy link
Owner

LGTM! Thanks! 3.0 is there. Lot's of thing to be revised :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants