Support timestamp characteristics #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijababi
force-pushed
the
mb.support_timestamp
branch
from
b857f9a to
c9acdd1
Compare
marijababi
requested review from
nikitabarskov,
VigdisIS,
rebwibsey and
Happycoil
as code owners
There was a problem hiding this comment.
To fix an issue with Datetime import error, you can import add this package to the library https://pypi.org/project/googleapis-common-protos/
|
Need to generate new python files from the protos, but cannot do it because I have a problem with earthly :( |
I can handover this PR then. |
Or I can take this over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/volur-ai/volur-ai-sdk-internal/issues/39
CI is failing because datetime proto isn't imported. (Had to be imported to apis repo, but I'll add it after we resolve the below comment)
I started adding datetime characteristic, but then figured out that it is not datetime that is needed, but timestamp.
There is a difference in google types between these too in a way that datetme proto has year, moth, day, hours, minutes and second, while timestamp has seconds and nanos.
Not sure what are we trying to achieve by adding the timestamp, so I added datetime