-
Notifications
You must be signed in to change notification settings - Fork 917
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
vcsim: add PropertyCollector index support
PropertyCollector supports use of index (unique key) to collect a single array element. Further, a property path may also be applied to the given element.
- Loading branch information
Showing
11 changed files
with
801 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /* | ||
| Copyright (c) 2024-2024 VMware, Inc. All Rights Reserved. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package object_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "reflect" | ||
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/vmware/govmomi/object" | ||
| "github.com/vmware/govmomi/property" | ||
| "github.com/vmware/govmomi/simulator" | ||
| "github.com/vmware/govmomi/vim25" | ||
| "github.com/vmware/govmomi/vim25/mo" | ||
| "github.com/vmware/govmomi/vim25/types" | ||
| ) | ||
|
|
||
| func TestExtensionMangerUpdates(t *testing.T) { | ||
| extension := types.Extension{ | ||
| Description: &types.Description{ | ||
| Label: "govmomi-test", | ||
| Summary: "Extension Manager test", | ||
| }, | ||
| Key: t.Name(), | ||
| Version: "0.0.1", | ||
| ShownInSolutionManager: types.NewBool(false), | ||
| } | ||
|
|
||
| description := extension.Description.GetDescription() | ||
|
|
||
| f := func(item string) string { | ||
| return (&mo.Field{Path: "extensionList", Key: extension.Key, Item: item}).String() | ||
| } | ||
|
|
||
| tests := []types.PropertyChange{ | ||
| {Name: f(""), Val: extension, Op: types.PropertyChangeOpAdd}, | ||
| {Name: f(""), Val: extension, Op: types.PropertyChangeOpAssign}, | ||
| {Name: f("description"), Val: *description, Op: types.PropertyChangeOpAssign}, | ||
| {Name: f("description.label"), Val: description.Label, Op: types.PropertyChangeOpAssign}, | ||
| {Name: f(""), Val: nil, Op: types.PropertyChangeOpRemove}, | ||
| } | ||
|
|
||
| simulator.Test(func(ctx context.Context, c *vim25.Client) { | ||
| m := object.NewExtensionManager(c) | ||
| pc := property.DefaultCollector(c) | ||
|
|
||
| for _, test := range tests { | ||
| t.Logf("%s: %s", test.Op, test.Name) | ||
| update := make(chan bool) | ||
| parked := sync.OnceFunc(func() { update <- true }) | ||
|
|
||
| var change *types.PropertyChange | ||
| cb := func(p []types.PropertyChange) bool { | ||
| parked() | ||
| change = &p[0] | ||
| if change.Op != test.Op { | ||
| t.Logf("ignore: change Op=%s, test Op=%s", change.Op, test.Op) | ||
| return false | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| go func() { | ||
| werr := property.Wait(ctx, pc, m.Reference(), []string{test.Name}, cb) | ||
| if werr != nil { | ||
| t.Log(werr) | ||
| } | ||
| update <- true | ||
| }() | ||
| <-update // wait until above go func is parked in WaitForUpdatesEx() | ||
|
|
||
| switch test.Op { | ||
| case types.PropertyChangeOpAdd: | ||
| if err := m.Register(ctx, extension); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| case types.PropertyChangeOpAssign: | ||
| if err := m.Update(ctx, extension); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| case types.PropertyChangeOpRemove: | ||
| if err := m.Unregister(ctx, extension.Key); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
| <-update // wait until update is received (cb returns true) | ||
|
|
||
| if change == nil { | ||
| t.Fatal("no change") | ||
| } | ||
|
|
||
| if change.Name != test.Name { | ||
| t.Errorf("Name: %s", change.Name) | ||
| } | ||
|
|
||
| if change.Op != test.Op { | ||
| t.Errorf("Op: %s", change.Op) | ||
| } | ||
|
|
||
| if !reflect.DeepEqual(change.Val, test.Val) { | ||
| t.Errorf("change.Val: %#v", change.Val) | ||
| t.Errorf("test.Val: %#v", test.Val) | ||
| } | ||
| } | ||
| }) | ||
| } |
Oops, something went wrong.