fix: fix assertion error when change display in input element.

vivo · Nov 27, 2023 · c8b8813 · c8b8813
1 parent e9b8efa
commit c8b8813
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/integration_tests/snapshots/dom/elements/input.ts.88ab73881.png b/integration_tests/snapshots/dom/elements/input.ts.88ab73881.png
diff --git a/integration_tests/specs/dom/elements/input.ts b/integration_tests/specs/dom/elements/input.ts
@@ -595,4 +595,23 @@ describe('Tags input', () => {
       done();
     });
   });
+
+  it('should works when change display on input element', (done) => {
+    const input = createElement('input', {
+      style: {
+        width: '50px'
+      }
+    }, []);
+    document.body.appendChild(input);
+    document.body.appendChild(createElement('span', {}, [createText('AAAAA')]))
+
+    requestAnimationFrame(async() => {
+      input.style.display = 'inline-block';
+      requestAnimationFrame((() => {
+
+      }))
+      await snapshot();
+      done();
+    });
+  });
 });
diff --git a/webf/lib/src/widget/widget_element.dart b/webf/lib/src/widget/widget_element.dart
@@ -84,10 +84,11 @@ abstract class WidgetElement extends dom.Element {
   @override
   void willAttachRenderer() {
     super.willAttachRenderer();
-    if (renderStyle.display != CSSDisplay.none) {
+    if (renderStyle.display != CSSDisplay.none && attachedAdapter == null) {
       attachedAdapter = WebFWidgetElementToWidgetAdapter(child: widget, container: renderBoxModel!, widgetElement: this);
     }
   }
+
   @mustCallSuper
   @override
   void didAttachRenderer() {