Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): show rollup error details as test error #6686

Merged
merged 5 commits into from
Oct 11, 2024
Merged

fix(vitest): show rollup error details as test error #6686

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
201121b
fix(vitest): show rollup error details as test error
hi-ogawa Oct 11, 2024
696bae9
refactor: minor
hi-ogawa Oct 11, 2024
c897d30
fix: copy error print from vite
hi-ogawa Oct 11, 2024
a0ff720
test: add test
hi-ogawa Oct 11, 2024
35f2fd2
refactor: move code
hi-ogawa Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: minor
  • Loading branch information
@hi-ogawa
hi-ogawa committed Oct 11, 2024
commit 696bae91a1eac59e5d6ba2bec2dc901e44624889
6 changes: 3 additions & 3 deletions packages/vitest/src/node/pools/rpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function createMethodsRPC(project: WorkspaceProject, options: MethodsOpti
return r?.map as RawSourceMap | undefined
},
async fetch(id, transformMode) {
const result = await project.vitenode.fetchResult(id, transformMode).catch(e => handleRollupError(e))
const result = await project.vitenode.fetchResult(id, transformMode).catch(handleRollupError)
const code = result.code
if (!cacheFs || result.externalize) {
return result
Expand Down Expand Up @@ -66,10 +66,10 @@ export function createMethodsRPC(project: WorkspaceProject, options: MethodsOpti
return { id: tmp }
},
resolveId(id, importer, transformMode) {
return project.vitenode.resolveId(id, importer, transformMode).catch(e => handleRollupError(e))
return project.vitenode.resolveId(id, importer, transformMode).catch(handleRollupError)
},
transform(id, environment) {
return project.vitenode.transformModule(id, environment).catch(e => handleRollupError(e))
return project.vitenode.transformModule(id, environment).catch(handleRollupError)
},
onPathsCollected(paths) {
ctx.state.collectPaths(paths)
Expand Down