Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): correctly resolve workspace globs and file paths #6316

Merged
merged 16 commits into from
Aug 12, 2024
Merged

fix(workspace): correctly resolve workspace globs and file paths #6316

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2a17f46
fix(vitest): correctly resolve workspace globs and file paths
sheremet-va Aug 9, 2024
403cd9a
refactor: move resolve workspaces to a separate file to make core sma…
sheremet-va Aug 12, 2024
76398b3
fix: use correct root
sheremet-va Aug 12, 2024
934d0c5
chore: docs
sheremet-va Aug 12, 2024
29fe833
test: update workspaces test
sheremet-va Aug 12, 2024
ad4e952
chore: improve error message
sheremet-va Aug 12, 2024
372a32f
fix: resolve config file correctly
sheremet-va Aug 12, 2024
5d41d7d
chore: cleanup
sheremet-va Aug 12, 2024
7d4ac23
chore: cleanup
sheremet-va Aug 12, 2024
043d30b
chore: cleanup
sheremet-va Aug 12, 2024
7dd1ab9
chore: cleanup
sheremet-va Aug 12, 2024
b9a7e1d
chore: cleanup
sheremet-va Aug 12, 2024
b1d60cc
test: workspace runs correctly with several configs
sheremet-va Aug 12, 2024
4df1024
test: more workspace tests
sheremet-va Aug 12, 2024
374c9d5
chore: add docs to workspace resolution
sheremet-va Aug 12, 2024
2c7a493
chore: remove resolve
sheremet-va Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: remove resolve
  • Loading branch information
@sheremet-va
sheremet-va committed Aug 12, 2024
commit 2c7a4933beec37b66f9807eaf7c358bd5d3048ae
3 changes: 1 addition & 2 deletions packages/vitest/src/node/workspace/resolveWorkspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ async function resolveWorkspaceProjectConfigs(

const workspacesFs = await fg(workspaceGlobMatches, globOptions)

await Promise.all(workspacesFs.map(async (filepath_) => {
const filepath = resolve(filepath_)
await Promise.all(workspacesFs.map(async (filepath) => {
// directories are allowed with a glob like `packages/*`
// in this case every directory is treated as a project
if (filepath.endsWith('/')) {
Expand Down
Loading