Tkakar/cat 946 map ensemble ids #1970
Conversation
examples/configs/src/index.js
Outdated
| @@ -50,7 +50,7 @@ import { alignedVisiumXeniumSpatialdata } from './view-configs/spatial-beta/spat | |||
| import { exemplarSmall2024, exemplarSmallPartialInit } from './view-configs/spatial-beta/exemplar-small.js'; | |||
| import { lake2023, lake2023component } from './view-configs/lake-2023.js'; | |||
| import { salcher2022 } from './view-configs/salcher_2022.js'; | |||
|
|
|||
| import { testConfig } from './view-configs/test.js'; | |||
There was a problem hiding this comment.
This is added for the PR-review purposes, I'll remove it once, reviewed.
|
Size Change: +3.42 kB (+0.02%) Total Size: 14.7 MB
ℹ️ View Unchanged
|
…46-map-ensemble-ids
There was a problem hiding this comment.
I refactored this to use the async function plugin API so that other developers could potentially extend the functionality by providing their own function that returns an alternative gene ID mapping object.
Feel free to merge after confirming that it works with the testConfig and removing that config
|
@keller-mark thanks for reviewing and refactoring. The marker genes on the scatter plot now show ensembile-ids. 
|
|
In which config? I am not seeing it on my end for http://localhost:3000/?dataset=test-config |
|
Thanks for testing. I'm using the same test-config, other views are showing. as long as it's working, should be good. |
This PR maps ensemble-gene-ids to gene-symbols when no gene symbols are provided in the data.
Fixes CAT-946
Background
Change List
Checklist