Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commonjs): ignoreDynamicRequires should default to false #4015

Merged
merged 1 commit into from
Jun 29, 2021
Merged

fix(commonjs): ignoreDynamicRequires should default to false #4015

merged 1 commit into from
Jun 29, 2021
+13 −4

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Jun 29, 2021 •
edited
Loading

Description

See #3353 (comment)

Comparing to the behavior before v2.3.1, the new default now throws a runtime error in the following case:

  • require(/* a dynamic expression */), where dynamicRequireTargets is specified, but the expression in the require call cannot be resolved via the targets.

Comparing to the behavior since v2.3.1, the new default fixes the following use case:

  • typeof require ==== 'function'

It is used in many legacy UMD bundles for CommonJS environment detection.

Fixes #3426
Fixes #3997

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit c08069c into vitejs:main Jun 29, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@haoqunjiang @aleclarson
fix(commonjs): ignoreDynamicRequires should default to false (vit…
3bc9624 
…ejs#4015)

See vitejs#3353 (comment)
Fixes vitejs#3426
Fixes vitejs#3997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@haoqunjiang @patak-dev