fix: Use a separate cached PostCSS config for each CSS plugin instantiation #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwouts
changed the title
|
Closing because #3906 already fixes this :) |
I'm sorry. I commented at first, but then I found out that my solution might have an issue when vite serve, so I deleted the comment to confirm the problem. |
|
No worries at all, either way we're better off with only one PR! Feel free to use my code if that helps too. |
Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PostCSS config is currently cached once for the entire lifetime of the Node process. This assumes that, for a given Node process, Vite only runs on a single project. That assumption breaks for example when using Vite's API to preview different projects, each with their own PostCSS config.
This PR moves the
cachedPostcssConfigvariable to thecssPluginfunction scope, so that each Vite server has its own independently cached value (enabling multiple projects to run in parallel).Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).