Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added clientPort to HmrOptions #3578

Merged
merged 4 commits into from
May 29, 2021
Merged

feat: added clientPort to HmrOptions #3578

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
766586b
feat: added clientPort to HmrOptions
johnnysprinkles May 28, 2021
cfc3e14
docs(hmr): describe the new clientPort option in server.hmr
johnnysprinkles May 28, 2021
9c765d8
feat(hmr): restored the String cast
johnnysprinkles May 28, 2021
3efde01
docs(hmr): not wrapping
johnnysprinkles May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(hmr): restored the String cast
  • Loading branch information
@johnnysprinkles
johnnysprinkles committed May 28, 2021
commit 9c765d880b7c43a537cfcbd40bdc602250e9dea1
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/clientInjections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function clientInjectionsPlugin(config: ResolvedConfig): Plugin {
if (typeof config.server.hmr === 'object') {
port = config.server.hmr.clientPort || config.server.hmr.port
}
port = port || 24678
port = String(port || 24678)
} else {
port = String(options.port || config.server.port!)
}
Expand Down