Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the return value of resolve by adding a namespace when processing a '@' in filter #3534

Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix: the return value of resolve by adding a namespace when processing a '@' in filter #3534

merged 1 commit into from
Aug 2, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented May 25, 2021

fixes #3532

Description

When the alias is equal to "@", the program will match "filter: / ^ [\ w @] [^:] /" and enter "build.onResolve". However, the return value of build.onResolve does not include the namespace, which causes the vue file to not be processed into HTML format.
After adding namespace in the return value of build.onResolve, the project work properly.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 25, 2021
@ygj6 ygj6 mentioned this pull request Jun 8, 2021
Closed
6 tasks
@ygj6 ygj6 mentioned this pull request Jun 29, 2021
Closed
6 tasks
@antfu antfu merged commit d4e979f into vitejs:main Aug 2, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@ygj6 @aleclarson
fix: the return value of resolve by adding a namespace when processin…
e0c887c 
…g a '@' in filter (vitejs#3534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

@nihalgonsalves nihalgonsalves Awaiting requested review from nihalgonsalves

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems caused by using alisaes and omitting file suffixes at the same time
4 participants
@ygj6 @patak-dev @Shinigami92 @antfu