Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle ssrLoadModule failures #2253

Merged
merged 1 commit into from
Feb 26, 2021
Merged

fix: handle ssrLoadModule failures #2253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: handle ssrLoadModule failures. closes #2252
  • Loading branch information
@Rich-Harris
Rich-Harris committed Feb 25, 2021
commit faea2c4d1a56e8ff1251685fda040367169be92d
2 changes: 1 addition & 1 deletion packages/vite/src/node/ssr/ssrModuleLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export async function ssrLoadModule(

const modulePromise = instantiateModule(url, server, context, urlStack)
pendingModules.set(url, modulePromise)
modulePromise.then(() => pendingModules.delete(url))
modulePromise.catch(() => {}).then(() => pendingModules.delete(url))
return modulePromise
}

Expand Down