Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should transform the img tag's srcset arrtibute and css' image-set property #2188

Merged
merged 3 commits into from
Feb 24, 2021
+149 −17
Merged

fix: should transform the img tag's srcset arrtibute and css' image-set property #2188

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32745d5
fix: should transform the img tag's srcset arrtibute and css' image-s…
HcySunYang Feb 23, 2021
5e9664d
fix: wrap with url()
HcySunYang Feb 23, 2021
452fc24
chore: simplify tests
HcySunYang Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: simplify tests
  • Loading branch information
@HcySunYang
HcySunYang committed Feb 23, 2021
commit 452fc240a6ebb4fe2c3e1e515cf7987f077bf33c
6 changes: 0 additions & 6 deletions packages/playground/assets/__tests__/assets.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,13 @@ describe('css url() references', () => {

test('image-set relative', async () => {
let imageSet = await getBg('.css-image-set-relative')
imageSet = imageSet.replace(/^-webkit-image-set\(/, '')
imageSet = imageSet.slice(0, -1)

imageSet.split(', ').forEach((s) => {
expect(s).toMatch(assetMatch)
})
})

test('image-set without the url() call', async () => {
let imageSet = await getBg('.css-image-set-without-url-call')
imageSet = imageSet.replace(/^-webkit-image-set\(/, '')
imageSet = imageSet.slice(0, -1)

imageSet.split(', ').forEach((s) => {
expect(s).toMatch(assetMatch)
})
Expand Down