Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom Angular variants #18410

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat: add custom Angular variants #18410

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c79daa
feat: add custom Analog.js variant
gioboa Oct 21, 2024
b15d1c1
feat: add custom Angular variant
gioboa Oct 21, 2024
ed46fdd
chore: change labels
gioboa Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: change labels
  • Loading branch information
@gioboa
gioboa authored Oct 21, 2024
commit ed46fddd13f1a8b51ca2c106bd6b679e77463637
4 changes: 2 additions & 2 deletions packages/create-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ const FRAMEWORKS: Framework[] = [
customCommand: 'npx -p @angular/cli@latest ng new TARGET_DIR',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gioboa Could this be npm exec @angular/cli@latest new TARGET_DIR instead? create-vite has special handling to execute the CLI with yarn/pnpm/bun dynamically if npm exec here is used, depending on the package manager that invoked create-vite in the first place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's working.
I created the PR #18425
Thanks

},
{
name: 'custom-analog-js',
display: 'Analog.js ↗',
name: 'custom-analog',
display: 'Analog ↗',
color: yellow,
customCommand: 'npm create analog@latest TARGET_DIR',
},
Expand Down