Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reload due to gsap and shiki #18397

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

patak-dev
Copy link
Member

Description

There are two reloads on cold start right now because of these late discovered deps

Copy link

stackblitz bot commented Oct 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment on lines +459 to +472
environments: {
client: {
dev: {
optimizeDeps: {
include: [
'@shikijs/vitepress-twoslash/client',
'gsap',
'gsap/dist/ScrollTrigger',
'gsap/dist/MotionPathPlugin',
],
},
},
},
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use dev.optimizeDeps directly, these deps are also optimized for the ssr environment. I think we will need to move the ssr optimize step (only for this default one?) to be lazy on the first transform call if we want to avoid this.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Oct 19, 2024
@patak-dev patak-dev merged commit 257883f into main Oct 19, 2024
10 checks passed
@patak-dev patak-dev deleted the docs/include-optmized-deps branch October 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants