Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce RunnableDevEnvironment #18190

Merged
merged 10 commits into from
Sep 27, 2024
Merged

feat: introduce RunnableDevEnvironment #18190

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
faf5148
feat: introduce RunnableDevEnvironment
sheremet-va Sep 24, 2024
af9fb34
docs: update
sheremet-va Sep 24, 2024
cac982f
chore: cleanup
sheremet-va Sep 24, 2024
f5b9612
refactor: remove environment.import
sheremet-va Sep 26, 2024
1182c73
docs: add RunnableDevEnvironment to docs
sheremet-va Sep 26, 2024
13546d5
fix: make "runner" eager
sheremet-va Sep 26, 2024
dd6e3d5
fix: allow any environment in isRunnableDevEnvironment
sheremet-va Sep 26, 2024
9ede269
chore: rename "runnerOptions" to "remoteRunner"
sheremet-va Sep 26, 2024
4ca025a
refactor: remove hot from default ssr env
sheremet-va Sep 27, 2024
8d53a09
docs: clarify
sheremet-va Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: allow any environment in isRunnableDevEnvironment
  • Loading branch information
@sheremet-va
sheremet-va committed Sep 26, 2024
commit dd6e3d5d79062f0125899f6c5d493cd85355d3df
3 changes: 2 additions & 1 deletion packages/vite/src/node/server/environments/runnableEnvironment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type { DevEnvironmentContext } from '../environment'
import { DevEnvironment } from '../environment'
import { createServerModuleRunner } from '../../ssr/runtime/serverModuleRunner'
import { createServerHotChannel } from '../hmr'
import type { Environment } from '../../environment'

export function createRunnableDevEnvironment(
name: string,
Expand All @@ -22,7 +23,7 @@ export interface RunnableDevEnvironmentContext extends DevEnvironmentContext {
}

export function isRunnableDevEnvironment(
environment: DevEnvironment,
environment: Environment,
): environment is RunnableDevEnvironment {
return environment instanceof RunnableDevEnvironment
}
Expand Down
Loading