Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce test flakiness #14684

Merged
merged 7 commits into from
Oct 19, 2023
Merged

chore: reduce test flakiness #14684

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed97feb
chore: fix lib dev flakiness
sapphi-red Oct 18, 2023
8a9b836
chore: fix hmr acceptExports log mismatch flakiness
sapphi-red Oct 18, 2023
bffb1e1
chore: fix hmr `page.waitForEvent('load')` flakiness
sapphi-red Oct 18, 2023
a1336ff
chore: fix hmr "keep hmr" test flakiness
sapphi-red Oct 18, 2023
e1ed71e
chore: fix external test flakiness
sapphi-red Oct 18, 2023
ecf7a7d
chore: fix proxy-hmr test flakiness
sapphi-red Oct 18, 2023
02efc8f
chore: serve the content from node_modules instead of public dir
sapphi-red Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix hmr acceptExports log mismatch flakiness 
should wait for hmr connection message,
otherwise that log will be used in the next `untilBrowserLogAfter`
  • Loading branch information
@sapphi-red
sapphi-red committed Oct 18, 2023
commit 8a9b836b552f811b114110b4fc0797c3d90a3099
4 changes: 2 additions & 2 deletions playground/hmr/__tests__/hmr.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ if (!isBuild) {

await untilBrowserLogAfter(
() => page.goto(`${viteTestUrl}/${testDir}/`),
'>>> ready <<<',
[CONNECTED, '>>> ready <<<'],
(logs) => {
expect(logs).toContain('loaded:some:a0b0c0default0')
expect(logs).toContain('some >>>>>> a0, b0, c0')
Expand All @@ -643,7 +643,7 @@ if (!isBuild) {
editFile(file, (code) => code.replace(/([abc])0/g, '$11'))
await page.waitForEvent('load')
},
'>>> ready <<<',
[CONNECTED, '>>> ready <<<'],
(logs) => {
expect(logs).toContain('loaded:some:a1b1c1default0')
expect(logs).toContain('some >>>>>> a1, b1, c1')
Expand Down