Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build time deps optimization, and ensure single crawl end call #12851

Merged
merged 8 commits into from
Apr 14, 2023
Merged

fix: build time deps optimization, and ensure single crawl end call #12851

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d01484
fix: ensure single crawl end call in optimizer
patak-dev Apr 13, 2023
959e0cf
fix: handle done() error
patak-dev Apr 13, 2023
b57c885
chore: donePromises never fail now
patak-dev Apr 14, 2023
9ae3e98
fix: separate crawlEndFinder lifecyle from firstRunCalled flag
patak-dev Apr 14, 2023
1efca7c
fix: setup crawl end finder in dev only for cold start
patak-dev Apr 14, 2023
475131f
chore: clean up
patak-dev Apr 14, 2023
13085c3
fix: reset crawler on build, not during dev
patak-dev Apr 14, 2023
c7c9e6c
fix: no missing deps when optimizing during build
patak-dev Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: clean up
  • Loading branch information
@patak-dev
patak-dev committed Apr 14, 2023
commit 475131f6ecf90f59ce625a87ceb59e61a311a5f1
7 changes: 0 additions & 7 deletions packages/vite/src/node/optimizer/optimizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,16 +693,9 @@ async function createDepsOptimizer(
}

// Called during buildStart at build time, when build --watch is used.
// Once during dev mode.
function resetRegisteredIds() {
crawlEndFinder?.cancel()
crawlEndFinder = setupOnCrawlEnd(onCrawlEnd)

// Cancel on-fly queued reruns. This shouldn't currently happen but makes
// the API of the optimizer more robust in case resetRegisteredIds wouldn't
// be called before the first request in dev mode
if (debounceProcessingHandle) clearTimeout(debounceProcessingHandle)
enqueuedRerun = undefined
}

function registerWorkersSource(id: string) {
Expand Down