Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-legacy): add option to output only legacy builds #10139

Merged
merged 8 commits into from
Jul 4, 2023
Merged

feat(plugin-legacy): add option to output only legacy builds #10139

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e2b9c4
feat(plugin-legacy): add option to output only legacy builds
amirkian007 Jul 30, 2022
bc407f0
fix(legacy): avoid generating modern chunks
lsdsjy Sep 16, 2022
62699f7
chore: fix readme
lsdsjy Sep 23, 2022
2e63b8a
fix: inline entry css if modern bundle is skipped
lsdsjy Oct 10, 2022
92278ef
Revert "fix: inline entry css if modern bundle is skipped"
lsdsjy Nov 21, 2022
933ecde
Merge branch 'main' into legacy-no-module
lsdsjy Jan 9, 2023
61e6148
Merge branch 'main' into pr/10139
sapphi-red Jun 22, 2023
3240bd2
refactor: tweak conditions
sapphi-red Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: inline entry css if modern bundle is skipped
  • Loading branch information
@lsdsjy
lsdsjy committed Nov 21, 2022
commit 2e63b8aeb630d26743844eb350530b0dcaf5ccac
11 changes: 11 additions & 0 deletions packages/plugin-legacy/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,17 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
}
},

renderStart(opts) {
// @ts-ignore
// In the `renderChunk` hook,
// we skip inlining CSS for the entry chunk because a separate CSS file
// would've been already linked in index.html (see #9761).
// But if `genModern` is set to false, the CSS still should be inlined.
// If in the future vite doesn't inline CSS any more (as #9920 suggests),
// this flag can be safely deleted.
opts.__vite_inline_entry_css__ = !genModern
},

async renderChunk(raw, chunk, opts) {
if (config.build.ssr) {
return null
Expand Down