Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vis#4042: Hide edges on zoom v2 #16

Merged
merged 15 commits into from
Jul 27, 2019
Merged

vis#4042: Hide edges on zoom v2 #16

merged 15 commits into from
Jul 27, 2019

Conversation

mojoaxel
Copy link
Member

This pull request was originally by @micahstubbs
almende/vis#4042

partially fixes #7

This PR adds a new network interaction option to hide edges on zoom, hideEdgesOnZoom

This new option is patterned after the existing hideEdgesOnDrag option.

fix almende/vis#4039

📄 steps to test

hide-edges-on-zoom-1

micahstubbs added 15 commits July 26, 2019 22:26
@micahstubbs @mojoaxel
enhance CanvasRenderer with new redrawZoom function that does not dra…
f4cffca 
…w edges during zoom
@micahstubbs @mojoaxel
call new _requestRedrawZoom function from zoom InteractionHandler
8c95eff
@micahstubbs @mojoaxel
use zoomStart and zoomEnd events
45fd293
@micahstubbs @mojoaxel
add this.zooming status to match this.dragging
a6d4621
@micahstubbs @mojoaxel
register hideEdgesOnZoom option
a794a1b
@micahstubbs @mojoaxel
document hideEdgesOnZoom
4a41ce1
@micahstubbs @mojoaxel
add type definition for hideEdgesOnZoom option
5626d0d
@micahstubbs @mojoaxel
add hideEdgesOnZoom to setOptions function in InteractionHandler
71aba0d
@micahstubbs @mojoaxel
set default option value for hideEdgesOnZoom in options config
eb399ca
@micahstubbs @mojoaxel
add redraw after zooming is complete
972ec05
@micahstubbs @mojoaxel
update neighborhoodHighlight example to use new hideEdgesOnZoom option
45033ca
@micahstubbs @mojoaxel
mute dev logging
97cd9c7
@micahstubbs @mojoaxel
remove commented code from earlier experiment
0c4f9bf
@micahstubbs @mojoaxel
restore newline
f3a7170
@micahstubbs @mojoaxel
restore newline above comment
993de55
@mojoaxel mojoaxel changed the title Hide edges on zoom v2 almende/vis#4042: Hide edges on zoom v2 Jul 26, 2019
@mojoaxel mojoaxel changed the title almende/vis#4042: Hide edges on zoom v2 vis#4042: Hide edges on zoom v2 Jul 26, 2019
yotamberk
yotamberk approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing this solution. It's a great solution to the problem!

@yotamberk yotamberk merged commit 482950f into master Jul 27, 2019
@yotamberk yotamberk deleted the hide-edges-on-zoom-v2 branch July 27, 2019 16:11
@mojoaxel mojoaxel mentioned this pull request Jul 27, 2019
Open
@mojoaxel mojoaxel added this to the v6 milestone Jul 27, 2019
@mojoaxel mojoaxel mentioned this pull request Jul 29, 2019
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamberk yotamberk yotamberk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6
3 participants
@mojoaxel @yotamberk @micahstubbs