Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the position generation for extruded polygons with holes #447

Merged
merged 2 commits into from
Mar 22, 2017
Merged

Fix the position generation for extruded polygons with holes #447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757aeba
Fix the position generation for extruded polygons with holes
Mar 22, 2017
fd2a464
Address review comments
Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review comments 
Fix the polygon layer example in the layer browser
  • Loading branch information
Shaojing Li committed Mar 22, 2017
commit fd2a4642ea3b2b9c320ecc667a7e2fda4726f8e5
4 changes: 2 additions & 2 deletions examples/layer-browser/src/examples/core-layers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const GeoJsonLayerExtrudedExample = {
props: {
id: 'geojsonLayer-extruded',
getElevation: f => get(f, 'properties.ZIP_CODE') * 10 % 127 * 10,
getFillColor: f => [0, 255, get(f, 'properties.ZIP_CODE') * 23 % 100 + 155],
getFillColor: f => [0, 100, get(f, 'properties.ZIP_CODE') * 55 % 255],
getLineColor: f => [200, 0, 80],
extruded: true,
wireframe: true,
Expand All @@ -110,7 +110,7 @@ const PolygonLayerExample = {
getData: () => dataSamples.polygons,
props: {
getPolygon: f => f,
getFillColor: f => [Math.random() % 256, 0, 0],
getFillColor: f => [Math.floor(Math.random() * 255), 0, 0],
getLineColor: f => [0, 0, 0, 255],
getWidth: f => 20,
getHeight: f => Math.random() * 1000,
Expand Down
1 change: 0 additions & 1 deletion src/layers/core/solid-polygon-layer/polygon-tesselator-extruded.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ export class PolygonTesselatorExtruded {
}

function countVertices(vertices) {

return vertices.reduce((vertexCount, polygon) => vertexCount + count(polygon), 0);
}

Expand Down