Change screenshot utilities

visgl · ajduberstein · Jul 9, 2019 · Jun 18, 2019 · Jun 18, 2019 · Jun 22, 2019
commit 3fccd37efc1d2280555d33ab131552558b884702
diff --git a/.travis.yml b/.travis.yml
@@ -56,7 +56,7 @@ matrix:
       before_install:
         # Enable user namespace cloning
         - cd bindings/python/pydeck
-        - export DISPLAY=:99.0; sh -e /etc/init.d/xvfb start
+        - export DISPLAY=:99.0; sh -e ./usr/bin/xvfb-run start
       python:
         - '3.5'
         - '2.7'

diff --git a/bindings/python/pydeck/tests/browser/screenshot_utils.py b/bindings/python/pydeck/tests/browser/screenshot_utils.py
@@ -66,8 +66,9 @@ async def go_to_page_and_screenshot(url, file_name, output_dir='.', sleep_second
             page_height = await get_notebook_page_height(page)
             # Set viewport height to larger page height in order to capture entire page in a screenshot
             await page.setViewport({'width': 768, 'height': page_height})
-        # Save out the screenshot
-        screenshot_path = os.path.join(output_dir, rename_png(file_name))
+        # Pytest passes POSIX paths, so we need to convert them to a string
+        str_path = str(output_dir)
+        screenshot_path = os.path.join(str_path, rename_png(file_name))
         logging.info("Writing screenshot to %s" % screenshot_path)
         await page._screenshotTask('png', {
             'path': screenshot_path,

diff --git a/bindings/python/pydeck/tests/browser/test_examples.py b/bindings/python/pydeck/tests/browser/test_examples.py
@@ -20,15 +20,15 @@
 
 
 def make_nb_url(ipynb, token):
-    return 'http://localhost:9876/notebooks/examples/' + urllib.parse.quote(ipynb) + '?token=' + token
+    return 'http://127.0.0.1:9876/notebooks/examples/' + urllib.parse.quote(ipynb) + '?token=' + token
 
 
 async def start_notebook():
     my_env = os.environ.copy()
     my_env['PYTHONPATH'] = "{}".format(jupyter_execution_directory)
     my_env['JUPYTER_TOKEN'] = token
     return subprocess.Popen(
-        './env3/bin/jupyter notebook --no-browser --port 9876',
+        'jupyter notebook --no-browser --port 9876 --ip 0.0.0.0 --allow-root',
         shell=True,
         cwd=jupyter_execution_directory,
         env=my_env)