Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ib/trivial updates #1324

Merged
merged 4 commits into from
Jan 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Ref: http://keepachangelog.com/en/0.3.0/

For Earlier Beta Releases see below


## Official Releases

### deck.gl v5.0 - Dec 21
Expand Down
7 changes: 5 additions & 2 deletions dev-docs/RFCs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,17 @@ These RFCs were implemented in v5.0. Also see luma.gl RFCs.
| --- | --- | --- | --- |
| **Animation** | | | |
| [**Auto Highlighting**](v5.0/auto-highlighting-rfc.md) | @ibgreen @1chandu | **Implemented** | Auto highlight hovered object via `picking` module |
| [**Viewport interpolation**](v5.0/viewport-animation-rfc.md) | @1chandu | **Experimental** | This should build on the new Viewport system in the First Person RFC. Also needs to consider react-map-gl. |
| [**Viewport Transitions**](v5.0/viewport-animation-rfc.md) | @1chandu | **Experimental** | Animate Viewport changes ("fly to" effect) through interpolation of Viewport props. (Also used in react-map-gl v3.2). |
| | | | |
| **Viewports and Controllers** | | | |
| [**First Person Geospatial Viewport**](v5.0/first-person-mercator-viewport-rfc.md) | @ibgreen | **Experimental** | Geospatially enable all viewports, add FirstPersonViewport for hybrid apps. |
| [**Multiple Viewports**](v5.0/multi-viewport-rfc.md) | @ibgreen | **Experimental** | Support for multiple viewports |
| | | | |
| **General** | | | |
| [**Break out EventManager**](v5.0/break-out-event-manager-rfc.md) | @ibgreen | **Implemented** | **Hygiene** Break out event manager module |
| [**Break out EventManager**](v5.0/break-out-event-manager-rfc.md) | @ibgreen | **Implemented** | Break out event manager module (mjolnir.js) |
| | | | |
| **luma.gl RFCs** | | | |
| **Break out Math Module** | @ibgreen | **Implemented** | Break out luma.gl math module (math.gl) |


## v4.1 RFCs
Expand Down
5 changes: 0 additions & 5 deletions src/core/pure-js/README.md

This file was deleted.

3 changes: 1 addition & 2 deletions src/experimental-layers/test/node-dist.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,5 @@ require('babel-polyfill');
// Import headless luma support
require('luma.gl/headless');

// require('./test-utils/setup-gl');
// Run the tests
require('./index');
require('../../../test/experimental-layers');
3 changes: 1 addition & 2 deletions src/experimental-layers/test/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,5 @@ require('babel-polyfill');
// Import headless luma support
require('luma.gl/headless');

// require('./test-utils/setup-gl');
// Run the tests
require('./index');
require('../../../test/experimental-layers');
7 changes: 5 additions & 2 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ import './src/imports-spec';
import './src/core';
import './src/core-layers';

// React test cases currently only work in browser
// TODO - React test cases currently only work in browser
// import './src/react';

// deck.gl-layers
import '../src/experimental-layers/test';
// TODO - Tests currently only work in browser
if (typeof document !== 'undefined') {
require('./src/experimental-layers');
}
2 changes: 1 addition & 1 deletion test/src/core-layers/geojson.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
getGeojsonFeatures,
separateGeojsonFeatures
} from 'deck.gl/core-layers/geojson-layer/geojson';
import {toJS} from 'deck.gl/core/experimental/container';
import {toJS} from 'deck.gl/core/experimental/utils/container';

const GEOMETRY = {type: 'Point'};
const FEATURE = {type: 'Feature', properties: [], geometry: GEOMETRY};
Expand Down
2 changes: 1 addition & 1 deletion test/src/core/experimental/container.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
isKeyedContainer,
keys,
entries
} from 'deck.gl/core/experimental/container';
} from 'deck.gl/core/experimental/utils/container';
// import Immutable from 'immutable';

const ITERATOR_TEST_CASES = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ test('Viewport constructor', t => {

t.ok(viewport, 'Viewport construction successful');

const viewportState = {};
const viewState = {};
Object.keys(viewportProps).forEach(key => {
viewportState[key] = viewport[key];
viewState[key] = viewport[key];
});

t.deepEquals(viewportState, viewportProps, 'Viewport props assigned');
t.deepEquals(viewState, viewportProps, 'Viewport props assigned');
t.end();
});

Expand Down
2 changes: 1 addition & 1 deletion website/src/stylesheets/_icon.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
font-variant: normal;
text-transform: none;

/* Better Font Rendering =========== */
/* Better Font Rendering === */
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
Expand Down