Change dead_letter_queue_max_size_in_bytes / size_in_bytes from count…

…er to gauge metrics
vincentlepot · Nov 16, 2023 · b5c6b0a · b5c6b0a
1 parent e188a17
commit b5c6b0a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -351,8 +351,8 @@ Table of exported metrics:
 | logstash_stats_jvm_uptime_millis | gauge | Uptime of the JVM in milliseconds. |
 | logstash_stats_pipeline_dead_letter_queue_dropped_events | counter | Number of events dropped by the dead letter queue. |
 | logstash_stats_pipeline_dead_letter_queue_expired_events | counter | Number of events expired in the dead letter queue. |
-| logstash_stats_pipeline_dead_letter_queue_max_size_in_bytes | counter | Maximum size of the dead letter queue in bytes. |
-| logstash_stats_pipeline_dead_letter_queue_size_in_bytes | counter | Current size of the dead letter queue in bytes. |
+| logstash_stats_pipeline_dead_letter_queue_max_size_in_bytes | gauge | Maximum size of the dead letter queue in bytes. |
+| logstash_stats_pipeline_dead_letter_queue_size_in_bytes | gauge | Current size of the dead letter queue in bytes. |
 | logstash_stats_pipeline_events_duration | counter | Time needed to process event. |
 | logstash_stats_pipeline_events_filtered | counter | Number of events that have been filtered out by this pipeline. |
 | logstash_stats_pipeline_events_in | counter | Number of events that have been inputted into this pipeline. |

diff --git a/collectors/nodestats/pipeline_subcollector.go b/collectors/nodestats/pipeline_subcollector.go
@@ -149,8 +149,8 @@ func (collector *PipelineSubcollector) Collect(pipeStats *responses.SinglePipeli
 	ch <- prometheus.MustNewConstMetric(collector.FlowWorkerConcurrencyLifetime, prometheus.CounterValue, float64(flowStats.WorkerConcurrency.Lifetime), pipelineID)
 
 	deadLetterQueueStats := pipeStats.DeadLetterQueue
-	ch <- prometheus.MustNewConstMetric(collector.DeadLetterQueueMaxSizeInBytes, prometheus.CounterValue, float64(deadLetterQueueStats.MaxQueueSizeInBytes), pipelineID)
-	ch <- prometheus.MustNewConstMetric(collector.DeadLetterQueueSizeInBytes, prometheus.CounterValue, float64(deadLetterQueueStats.QueueSizeInBytes), pipelineID)
+	ch <- prometheus.MustNewConstMetric(collector.DeadLetterQueueMaxSizeInBytes, prometheus.GaugeValue, float64(deadLetterQueueStats.MaxQueueSizeInBytes), pipelineID)
+	ch <- prometheus.MustNewConstMetric(collector.DeadLetterQueueSizeInBytes, prometheus.GaugeValue, float64(deadLetterQueueStats.QueueSizeInBytes), pipelineID)
 	ch <- prometheus.MustNewConstMetric(collector.DeadLetterQueueDroppedEvents, prometheus.CounterValue, float64(deadLetterQueueStats.DroppedEvents), pipelineID)
 	ch <- prometheus.MustNewConstMetric(collector.DeadLetterQueueExpiredEvents, prometheus.CounterValue, float64(deadLetterQueueStats.ExpiredEvents), pipelineID)