Merge pull request kubernetes#15944 from mqliang/assignoutloop

Move assignment statement out of loop
vikram · Oct 21, 2015 · 236193a · 236193a
2 parents d4de35e + 1638607
commit 236193a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/controller/daemon/controller.go b/pkg/controller/daemon/controller.go
@@ -406,11 +406,12 @@ func storeDaemonSetStatus(dsClient client.DaemonSetInterface, ds *extensions.Dae
 		return nil
 	}
 
+	ds.Status.DesiredNumberScheduled = desiredNumberScheduled
+	ds.Status.CurrentNumberScheduled = currentNumberScheduled
+	ds.Status.NumberMisscheduled = numberMisscheduled
+
 	var updateErr, getErr error
 	for i := 0; i <= StatusUpdateRetries; i++ {
-		ds.Status.DesiredNumberScheduled = desiredNumberScheduled
-		ds.Status.CurrentNumberScheduled = currentNumberScheduled
-		ds.Status.NumberMisscheduled = numberMisscheduled
 		_, updateErr = dsClient.UpdateStatus(ds)
 		if updateErr == nil {
 			// successful update