Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 360_CUBE projection #86

Merged
merged 5 commits into from
May 23, 2018
Merged

Handle 360_CUBE projection #86

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13fdf86
Handle 360_CUBE projection
dillontiner May 12, 2018
31badfd
Handle 360_CUBE projection
dillontiner May 12, 2018
87f1ef4
cubemap video sample
dillontiner May 14, 2018
d0021ac
this.movieMaterial defined in each projection and orient cubemap face…
dillontiner May 15, 2018
c206e39
this.movieMaterial defined in each projection and orient cubemap face…
dillontiner May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added samples/doisethup_cubemap.mp4
View file
Open in desktop
Binary file not shown.
36 changes: 18 additions & 18 deletions src/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,34 +163,33 @@ class VR extends Plugin {
this.scene.add(this.movieScreen);

} else if (projection === '360_CUBE') {
// Currently doesn't work - need to figure out order of cube faces
this.movieGeometry = new THREE.CubeGeometry(256, 256, 256);
this.movieGeometry = new THREE.BoxGeometry(256, 256, 256);
const face1 = [new THREE.Vector2(0, 0.5), new THREE.Vector2(0.333, 0.5), new THREE.Vector2(0.333, 1), new THREE.Vector2(0, 1)];
const face2 = [new THREE.Vector2(0.333, 0.5), new THREE.Vector2(0.666, 0.5), new THREE.Vector2(0.666, 1), new THREE.Vector2(0.333, 1)];
const face3 = [new THREE.Vector2(0.666, 0.5), new THREE.Vector2(1, 0.5), new THREE.Vector2(1, 1), new THREE.Vector2(0.666, 1)];
const face4 = [new THREE.Vector2(0, 0), new THREE.Vector2(0.333, 1), new THREE.Vector2(0.333, 0.5), new THREE.Vector2(0, 0.5)];
const face5 = [new THREE.Vector2(0.333, 1), new THREE.Vector2(0.666, 1), new THREE.Vector2(0.666, 0.5), new THREE.Vector2(0.333, 0.5)];
const face6 = [new THREE.Vector2(0.666, 1), new THREE.Vector2(1, 0), new THREE.Vector2(1, 0.5), new THREE.Vector2(0.666, 0.5)];
const face4 = [new THREE.Vector2(0, 0), new THREE.Vector2(0.333, 0), new THREE.Vector2(0.333, 0.5), new THREE.Vector2(0, 0.5)];
const face5 = [new THREE.Vector2(0.333, 0), new THREE.Vector2(0.666, 0), new THREE.Vector2(0.666, 0.5), new THREE.Vector2(0.333, 0.5)];
const face6 = [new THREE.Vector2(0.666, 0), new THREE.Vector2(1, 0), new THREE.Vector2(1, 0.5), new THREE.Vector2(0.666, 0.5)];

this.movieGeometry.faceVertexUvs[0] = [];

this.movieGeometry.faceVertexUvs[0][0] = [ face1[0], face1[1], face1[3] ];
this.movieGeometry.faceVertexUvs[0][1] = [ face1[1], face1[2], face1[3] ];
this.movieGeometry.faceVertexUvs[0][0] = [ face1[3], face1[0], face1[2] ];
this.movieGeometry.faceVertexUvs[0][1] = [ face1[0], face1[1], face1[2] ];

this.movieGeometry.faceVertexUvs[0][2] = [ face2[0], face2[1], face2[3] ];
this.movieGeometry.faceVertexUvs[0][3] = [ face2[1], face2[2], face2[3] ];
this.movieGeometry.faceVertexUvs[0][2] = [ face2[3], face2[0], face2[2] ];
this.movieGeometry.faceVertexUvs[0][3] = [ face2[0], face2[1], face2[2] ];

this.movieGeometry.faceVertexUvs[0][4] = [ face3[0], face3[1], face3[3] ];
this.movieGeometry.faceVertexUvs[0][5] = [ face3[1], face3[2], face3[3] ];
this.movieGeometry.faceVertexUvs[0][4] = [ face3[3], face3[0], face3[2] ];
this.movieGeometry.faceVertexUvs[0][5] = [ face3[0], face3[1], face3[2] ];

this.movieGeometry.faceVertexUvs[0][6] = [ face4[0], face4[1], face4[3] ];
this.movieGeometry.faceVertexUvs[0][7] = [ face4[1], face4[2], face4[3] ];
this.movieGeometry.faceVertexUvs[0][6] = [ face4[3], face4[0], face4[2] ];
this.movieGeometry.faceVertexUvs[0][7] = [ face4[0], face4[1], face4[2] ];

this.movieGeometry.faceVertexUvs[0][8] = [ face5[0], face5[1], face5[3] ];
this.movieGeometry.faceVertexUvs[0][9] = [ face5[1], face5[2], face5[3] ];
this.movieGeometry.faceVertexUvs[0][8] = [ face5[3], face5[0], face5[2] ];
this.movieGeometry.faceVertexUvs[0][9] = [ face5[0], face5[1], face5[2] ];

this.movieGeometry.faceVertexUvs[0][10] = [ face6[0], face6[1], face6[3] ];
this.movieGeometry.faceVertexUvs[0][11] = [ face6[1], face6[2], face6[3] ];
this.movieGeometry.faceVertexUvs[0][10] = [ face6[3], face6[0], face6[2] ];
this.movieGeometry.faceVertexUvs[0][11] = [ face6[0], face6[1], face6[2] ];

this.movieScreen = new THREE.Mesh(this.movieGeometry, this.movieMaterial);
this.movieScreen.position.set(position.x, position.y, position.z);
Expand Down Expand Up @@ -387,7 +386,8 @@ class VR extends Plugin {
this.videoTexture.magFilter = THREE.LinearFilter;
this.videoTexture.format = THREE.RGBFormat;

this.movieMaterial = new THREE.MeshBasicMaterial({ map: this.videoTexture, overdraw: true, side: THREE.FrontSide });
// double sided to render inside of cube
this.movieMaterial = new THREE.MeshBasicMaterial({ map: this.videoTexture, overdraw: true, side: THREE.DoubleSide });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we may just want to put this in this.changeprojection_ and have a separate creation in 360, 360_TR/360_LR, and 360_CUBE. Previously we had this set to DoubleSide but it results in un-needed drawing on the outside of the sphere in 360.


this.changeProjection_(this.currentProjection_);

Expand Down