Remove --concurrency-target Flag from knative.sh #583
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing the --concurrency-target flag from the knative.sh script as it conflicts with the containerConcurrency setting defined in trace_func_go.yaml. Since containerConcurrency specifies a hard limit, adding a soft limit via --concurrency-target=1 can lead to unexpected behaviour when containerConcurrency > 1.
Details
Hard Limit: Configured via containerConcurrency, strictly enforces the maximum concurrent requests per container.
Soft Limit: Configured via --concurrency-target or autoscaling.knative.dev/target, is a guideline that can be exceeded.
When both limits exist, the smaller value takes precedence. Removing the redundant soft limit avoids conflicts and ensures predictable scaling behaviour.
More information provided in Knative documentation: https://knative.dev/docs/serving/autoscaling/concurrency/