-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new engine: fission reactor #36853
base: Bleeding-Edge
Are you sure you want to change the base?
new engine: fission reactor #36853
Conversation
Can't wait to build a reactor with a shard in the middle, singulo generators on the sides, surrounded by AME walls, all the while a particle accelerator blasts waves. |
There should be ambient radiation release that is very low or 0 when running optimally but grows larger as the reactor begins to fail so that I can say "2.7 rotenogen" |
2.7 roentgens... |
STOP REVIEWING THE CODE IT'S NOT DONE YET |
Assuming this works...similarly to how a real fission reactor works, cooling fuel rods is a must- will cryotheum be useful for cooling down rods or are you planning on possibly implementing its own method for cooling down rods? i.e tanks full of chilled water, etc. Any plans on adding heavy water? It would be sort of pointless, but I do think having an engine that requires a bit more attention and some real world knowledge would make for a frustrating but fun way to play engineering. |
a lot of liberties will be taken
nope. rods from the reactor will be safe to handle no matter what, as of what's planned for now. |
Are fuel rods just going to be an item you buy from cargo or will it be something science makes? |
you can order it from cargo in a fission reactor setup crate |
Perhaps I'm being bold, but I do think giving uranium another purpose might be a good reason to incentivize this to be something science produces; however I do think that given how easy it is to make RTG cells, fuel rods would go unnoticed. |
>implying scientists ever make anything that doesn't also benefit them |
still keeping the DNM on amphibian's request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopping the review as there is still a large amount of debug code in here. Remove your debug code and address what I've added so far then I will continue.
for(var/obj/machinery/fissionreactor/fissionreactor_fuelrod/fuelrod in fuel_rods) //dissassociate all parts (if any still exist). | ||
fuelrod.associated_reactor=null | ||
fuel_rods=list() | ||
for(var/obj/machinery/fissionreactor/fissionreactor_controlrod/controlrod in control_rods) | ||
controlrod.associated_reactor=null | ||
control_rods=list() | ||
for(var/obj/structure/fission_reactor_case/casing in casing_parts) | ||
casing.associated_reactor=null | ||
casing_parts=list() | ||
for(var/obj/machinery/atmospherics/unary/fissionreactor_coolantport/coolport in coolant_ports) | ||
coolport.associated_reactor=null | ||
coolant_ports=list() | ||
if(controller) | ||
controller.associated_reactor=null | ||
controller=null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but using weakrefs mitigates the need for this entirely.
…ian/vgstation13 into edging-my-demon-core
Alright he told me its ready |
So tell him to update the PR description and set it to "ready" |
He's on vacation, merge the PR please |
[dmn] [wip] [content] [needspritework]
WIP DO NOT MERGE THIS IT WILL NOT WORK YET PLEASE
todo:
What this does
adds fission reactors - a new way to generate power. fission reactors are made by assembling several tiles together to form a structure. what you place in this structure affects its properties
fuels
the fission reactor takes a fuel mixture. the contents of the mixture affect the power output, as well as duration of the fuel (these 2 variables are further affected by the design of the reactor itself). additionally, the contents will transform into others when going through this process.
the reactor itself
the reactor creates a lot of heat, so make sure you add some coolant ports to it. failure to do so will result in a meltdown. It accepts 1 fuel container at a time, though it can be ejected at any moment if you wish to tweak the mixture.
the internals of the reactor consist of control rods and fuel rods.
fuel rods are where the fission happens. more fuel rods = more power, but faster use. when fuel rods are placed adjacent to another, they receive a bonus to their output at no cost of fuel duration!
of course, to throttle your reactor, you will need control rods. without any control rods, you cannot shut the reactor down! (for the most daring of engineers to attempt.) control rods are able to affect to affect up to 8 fuel rods which surround it. each fuel rod only needs 1 control rod to shut off, but this is (theoretically) optional.
making the fuels
a special machine will be added which can properly dispense, and analyze a fuel mixture to inform you of it's estimated lifetime and heat generation power. This same machine also recycles spent fuel into its new fission byproducts.
new materials!
Radon
Lead
Thallium
Plutonium
Regenerate Calcium
irradiation framework
future fission reactions can easily be added to a reagent with the use of an easy to use irradiate() proc, allowing easy integration with other content
Why it's good
adds a new way to get power, as well as some fun toying with fuel mixtures and seeing what happens to materials you place into the reactor, in addition to allowing you to get your hand on some materials in an alternate way.
plus, the new materials to do things with!
How it was tested
still WIP, so not yet.
Changelog
🆑