These tests pass now:

• examples/checker_tests/bad/issue407-1.p4
• examples/checker_tests/bad/header3.p4
• examples/checker_tests/bad/stack_e.p4

However, test examples/checker_tests/bad/twovarbit.p4 still fails.

I am not sure if it is kosher or not for a header to have multiple varbit<w> fields. Section 7.2.2. Header Types does not seem to mention any such restriction for headers in general.

However, as described in Section 12.8.2. Variable width extraction, Headers passed into extract may only have up to one varbit<w> field.

Should the restriction on the number of varbit<w> fields in a header be imposed generally, or just for the case of extract?

Recursive headers are now verboten.

Test examples/checker_tests/bad/issue2290.p4 now passes

Everything's passing except the twovarbit thing. I asked over at the p4c repo about it since it seemed like something that should get checked at extract() calls and not at header definitions: p4lang/p4c#2445

p4lang/p4-spec#876