Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Petr4 should catch name shadowing #135

Open
hackedy opened this issue May 9, 2020 · 2 comments
Open

Petr4 should catch name shadowing #135

hackedy opened this issue May 9, 2020 · 2 comments
Assignees
@hackedy
Labels
typechecker

Comments

@hackedy
Copy link
Collaborator

hackedy commented May 9, 2020

Tests failing because of this:

  • examples/checker_tests/bad/issue1541.p4
  • examples/checker_tests/bad/template_e.p4
  • examples/checker_tests/bad/issue1932.p4
  • examples/checker_tests/bad/accept_e.p4
  • examples/checker_tests/bad/dup-param.p4
  • examples/checker_tests/bad/dupConst.p4
@hackedy
Copy link
Collaborator Author

hackedy commented May 12, 2020

Marking this unsupported mostly because the spec is ambiguous and I'm not sure how strict I would want petr4 to be about it.

@hackedy hackedy self-assigned this Jun 19, 2020
@hackedy hackedy mentioned this issue Jun 22, 2020
Closed
@hackedy hackedy mentioned this issue Jun 25, 2020
Closed
@hackedy
Copy link
Collaborator Author

hackedy commented Jun 27, 2020

Raising an error for duplicated parameters in a single declaration or for duplicated type parameters in a single declaration deals with most of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackedy hackedy

Labels
typechecker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hackedy