Added Month support (30 Days) #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not entirely sure how to toggle between 30 and 31 days effectively so if anyone can do that please help!
|
Hi @WeTogetherStrong, interesting - and good point. Not sure how we can best handle that? It might be why it wasn't included to begin with. It would be tedious to have to pass it through, and we can't auto-detect. |
|
I'd recommend considering the month to be an average of days between 28 and 31 |
|
I'd suggest a month is year / 12 so the ms all add up properly |
|
That would be more logical, As the Year day count is statically defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure how to toggle between 30 and 31 days effectively so if anyone can do that please help!