Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Int overflow when calculating viewport area position in large files #203

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

ru5k
Copy link

@ru5k ru5k commented Mar 5, 2018

I had some scrolling problems with large files (more than 6000 lines) in my projects. I think it also relates to the existing issue #178.

@vektah
Copy link
Owner

vektah commented Mar 6, 2018

This seems to make it very sluggish.

before:
before

after:
after

see how the scroll area isnt keeping up with the mouse?

@ru5k
Copy link
Author

ru5k commented Mar 7, 2018

Tested various implementations using doubles, floats, longs. For me the performance was about the same in all cases. May be it is test configuration dependent.

And about scrolling itself: actually area is not catching cursor - it catches the line to which cursor points at file image. For the very large files it is more noticeable. Were the files in your test of the same length and with the same 'Pixels Per Line' used?

@MartinZubek
Copy link

Hopefully this gets fixed soon, because the scrolling area "floating" under cursor for large files is really annoying.

@MartinZubek
Copy link

Any updates, guys? :)

@vektah vektah merged commit c50cabe into vektah:master Mar 28, 2018
@vektah
Copy link
Owner

vektah commented Mar 28, 2018

Thanks for the PR, sorry it took so long to get it shipped. I'll cut a new release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants