detect Varnish instances and try to be helpful #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One Karnaugh map later and I realized that #116 (comment) could have been expressed more simply. If `varnishadm ping` is successful with the current NAME argument, no question asked, go for it: ``` Info: Working directory: /tmp/varnishgather.Z1LTcYva/varnishgather-flamp-20241106-214646 Info: Complete varnishadm command line deduced to: Task: 1: varnishd -V ... ``` If pinging failed, there are a few cases: If NAME was given, or if NAME wasn't given but there's no varnishd detected, issue a warning, pause a bit, then proceed: ``` Info: Working directory: /tmp/varnishgather.BBE414gf/varnishgather-flamp-20241106-221201 using: varnishadm ping, We couldn't ping varnishd, Is it running and is ./varnishgather running with the right permissions? Info: Complete varnishadm command line deduced to: <PAUSE 10s> Task: 1: varnishd -V ... ``` if no NAME was given but there's exactly one candidate, and it's pingable, override NAME, warn about it, pause then proceed: ``` Info: Working directory: /tmp/varnishgather.ZeUDcfg7/varnishgather-flamp-20241106-222151 using: varnishadm ping, We couldn't ping varnishd, Is it running and is ./varnishgather running with the right permissions? There's only one varnishd running and it's pingable. Overriding -n argument to /tmp/beepboop <PAUSE 10s> Info: Complete varnishadm command line deduced to: -n /tmp/beepboop Task: 1: varnishd -V ... ``` If no NAME is given, and there's only one candidate but it's not pingable, just error out: ``` Info: Working directory: /tmp/varnishgather.eZSa78VU/varnishgather-flamp-20241106-224856 using: varnishadm ping, We couldn't ping varnishd, Is it running and is ./varnishgather running with the right permissions? <EXIT> ``` Finally, if there are no given NAME, and we have more than one candidate, we just propose a list of candidates and error out: ``` Info: Working directory: /tmp/varnishgather.dkGgfqHe/varnishgather-flamp-20241106-223210 using: varnishadm ping, We couldn't ping varnishd, Is it running and is ./varnishgather running with the right permissions? We've also detected one or more varnishd that could possibly be pinged with these -n arguments: -n /tmp/beepboop -n /tmp/beepboop2 <EXIT> ```
gquintard
force-pushed
the
n_arg_detection
branch
from
45c79f1 to
d5c4244
Compare
|
I dont have any objections, it seems to work but is a bit unreadable :) (but so is the rest of the code) |
simonvik
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One Karnaugh map later and I realized that #116 (comment)
could have been expressed more simply:
-nwas given: warn then proceed-n:Read on for example outputs.
If
varnishadm pingis successful with the current NAME argument, noquestion asked, go for it:
If pinging failed, there are a few cases:
If NAME was given, or if NAME wasn't given but there's no varnishd
detected, issue a warning, pause a bit, then proceed:
if no NAME was given but there's exactly one candidate, and it's
pingable, override NAME, warn about it, pause then proceed:
If no NAME is given, and there's only one candidate but it's not
pingable, just error out:
Finally, if there are no given NAME, and we have more than one
candidate, we just propose a list of candidates and error out:
@hermunn and @zackmay, tagging you in as you were part of the original discussion.