-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates #188
Dependency updates #188
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
app_package_name 'com.vanniktech.emoji.sample' | ||
use_tests_in_packages ['com.vanniktech.emoji.sample.screenshots'] | ||
|
||
app_apk_path 'app/build/outputs/apk/app-0.5.0-SNAPSHOT-debug.apk' | ||
tests_apk_path 'app/build/outputs/apk/app-0.5.0-SNAPSHOT-debug-androidTest.apk' | ||
app_apk_path 'app/build/outputs/apk/app-0.6.0-SNAPSHOT-debug.apk' | ||
tests_apk_path 'app/build/outputs/apk/app-0.6.0-SNAPSHOT-debug-androidTest.apk' | ||
|
||
locales ['en-US'] | ||
|
||
clear_previous_screenshots true | ||
clear_previous_screenshots true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,8 @@ apply plugin: 'com.vanniktech.android.junit.jacoco' | |
|
||
buildscript { | ||
ext.versions = [ | ||
testRules: '0.5', | ||
espresso: '3.0.0', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Concerning screengrab: Something set a different version, so I redefinied it here. Why does that happen? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh it was simply missing here in the first place. Now it should be all good. |
||
testRules: '1.0.0', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i haven't had luck with 1.0.0 and espresso 3.0.0. Did you test locally whether the screenshots are being taken or not. You can do so using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right, at first it did not work. Managed to fix with my latest commit though. |
||
] | ||
|
||
ext.deps = [ | ||
|
@@ -17,7 +18,7 @@ buildscript { | |
'rules': "com.android.support.test:rules:${versions.testRules}", | ||
], | ||
], | ||
'fastLaneScreenGrab': "tools.fastlane:screengrab:1.0.3", | ||
'fastLaneScreenGrab': "tools.fastlane:screengrab:1.1.0", | ||
] | ||
|
||
repositories { | ||
|
@@ -26,7 +27,7 @@ buildscript { | |
} | ||
dependencies { | ||
classpath 'com.vanniktech:gradle-code-quality-tools-plugin:0.7.0' | ||
classpath 'com.vanniktech:gradle-android-junit-jacoco-plugin:0.6.0' | ||
classpath 'com.vanniktech:gradle-android-junit-jacoco-plugin:0.7.0' | ||
|
||
classpath 'com.android.tools.build:gradle:2.3.3' | ||
classpath 'com.github.ben-manes:gradle-versions-plugin:0.15.0' | ||
|
@@ -52,9 +53,6 @@ codeQualityTools { | |
errorProne { | ||
toolVersion = '2.0.21' | ||
} | ||
cpd { | ||
ignoreFailures = true // Fix in a follow up. | ||
} | ||
} | ||
|
||
junitJacoco { | ||
|
@@ -74,11 +72,11 @@ subprojects { | |
|
||
ext { | ||
minSdkVersion = 15 | ||
compileSdkVersion = 25 | ||
targetSdkVersion = 25 | ||
buildToolsVersion = '25.0.3' | ||
compileSdkVersion = 26 | ||
targetSdkVersion = 26 | ||
buildToolsVersion = '26.0.1' | ||
|
||
supportLibraryVersion = '25.4.0' | ||
supportLibraryVersion = '26.0.0' | ||
leakCanaryVersion = '1.5.1' | ||
|
||
versionCode = VERSION_CODE | ||
|
@@ -96,8 +94,8 @@ ext { | |
|
||
testing = [ | ||
junit : 'junit:junit:4.12', | ||
robolectric : 'org.robolectric:robolectric:3.3.2', | ||
mockito : 'org.mockito:mockito-core:2.8.9', | ||
robolectric : 'org.robolectric:robolectric:3.4.2', | ||
mockito : 'org.mockito:mockito-core:2.8.47', | ||
privateConstructor: 'com.pushtorefresh.java-private-constructor-checker:checker:1.2.0', | ||
assertJ : 'org.assertj:assertj-core:3.8.0' | ||
] | ||
|
@@ -106,6 +104,6 @@ ext { | |
} | ||
|
||
task wrapper(type: Wrapper) { | ||
gradleVersion = '4.0' | ||
gradleVersion = '4.0.2' | ||
distributionType = Wrapper.DistributionType.ALL | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,16 +189,6 @@ public void noProviderInstalled() { | |
assertThat(text.getSpans(0, text.length(), EmojiSpan.class)).hasSize(1); | ||
} | ||
|
||
@Test public void takeLongest() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a duplicate of the |
||
EmojiManager.install(provider); | ||
|
||
final Spannable text = new SpannableString(new String(new int[] { 0x1234, 0x4321 }, 0, 1)); | ||
|
||
EmojiManager.replaceWithImages(RuntimeEnvironment.application, text, 22); | ||
|
||
assertThat(text.getSpans(0, text.length(), EmojiSpan.class)).hasSize(1); | ||
} | ||
|
||
@Test public void empty() { | ||
EmojiManager.install(provider); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#Mon Jun 19 17:19:50 CEST 2017 | ||
#Mon Aug 07 14:31:22 CEST 2017 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.0-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.0.2-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found here: https://stackoverflow.com/a/18625921/4279995
Not optimal, but I think there is no better way...