Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser window is opened again on redeploy after a while #19506

Open
Legioth opened this issue Jun 4, 2024 · 6 comments
Open

Browser window is opened again on redeploy after a while #19506

Legioth opened this issue Jun 4, 2024 · 6 comments
Labels
bug development mode Impact: Low Severity: Minor

Comments

@Legioth
Copy link
Member

Legioth commented Jun 4, 2024

Description of the bug

Seems like the new logic with a timeout to avoid re-opening the browser window for each server start is also triggered for redeploys and not only when the server is newly started.

Expected behavior

Expected that the browser opening logic is triggered only when starting the dev server but not when only redeploying an already running server.

Minimal reproducible example

  1. Get a Spring Boot application with Vaadin 24.4 from start.vaadin.com
  2. Start the app, observe that a browser window is opened.
  3. Make a code change, observe that the app is redeployed but no browser window is opened.
  4. Leave the application open for a while (30 min iirc)
  5. Make a code change, observe that a new browser window is opened when the application redeploys.

Versions

  • Vaadin / Flow version: Vaadin 24.4.0.beta5
@caalador
Copy link
Contributor

caalador commented Jun 4, 2024

This is a known problem as we can't know why the server is running the code or if there is a browser tab open.

The timeout was decided for being ok enough for normal development cycle and can be extended/shortened as needed.

@mshabarov mshabarov moved this to 🔖 Low Priority (P3) in Vaadin Flow bugs & maintenance (Vaadin 10+) Jun 4, 2024
@Legioth
Copy link
Member Author

Legioth commented Jun 4, 2024

I think you miss the point. The previous implementation only did things when the server was started but not for redeploys. The new implementation also does things for redeploys (after the timeout). It shouldn't do anything for redeploys regardless of the timeout.

@caalador
Copy link
Contributor

caalador commented Jun 4, 2024

It should work the same as before and return the system property value if time has run out since file creation.
The only thing added was the don't check system property if file created before timeout

flow/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/BrowserLauncher.java

Line 74 in b23c0b7

return true;

Need to be investigated.

@Legioth
Copy link
Member Author

Legioth commented Jun 5, 2024

The logic seems solid. Maybe I was actually restarting the server without realizing it? Will try to remember to leave it running over lunch again and see if it reproduces.

@Legioth
Copy link
Member Author

Legioth commented Jun 5, 2024

Can't reproduce now. Must have been a fluke.

@Legioth Legioth closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Low Priority (P3) to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Jun 5, 2024
@Legioth
Copy link
Member Author

Legioth commented Jun 11, 2024

Happened again now and this time I'm certain I didn't restart the server. But I also don't have any additional clues on what goes on here.

@Legioth Legioth reopened this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug development mode Impact: Low Severity: Minor
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Legioth @caalador @mshabarov